You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since all data and command are top-level, it's hard to distinguish data key (like "name", "description", etc.) from command ("parse", "discard", "move").
Also, in the current state, each new command is a backward incompatible change because you never know if someone was not using your new command name as a key for data.
My proposition would be to create a key "data" that would contain all the data you want to pollinate in your template, so the separation between data and command is clearer,
for backward compatibility sake, both using data or putting data in the top level could work for now.
An alternative solution would be to prefix all command with a character like _ and to refuse data key starting with the same character, thus again separating the domain space of the keys.
As an aside, it would also be nice to have in the readme the complete list of command keyword near the top,
This is a very nice project, hope you can keep it up!
The text was updated successfully, but these errors were encountered:
Since all data and command are top-level, it's hard to distinguish data key (like "name", "description", etc.) from command ("parse", "discard", "move").
Also, in the current state, each new command is a backward incompatible change because you never know if someone was not using your new command name as a key for data.
My proposition would be to create a key "data" that would contain all the data you want to pollinate in your template, so the separation between data and command is clearer,
for backward compatibility sake, both using data or putting data in the top level could work for now.
An alternative solution would be to prefix all command with a character like
_
and to refuse data key starting with the same character, thus again separating the domain space of the keys.As an aside, it would also be nice to have in the readme the complete list of command keyword near the top,
This is a very nice project, hope you can keep it up!
The text was updated successfully, but these errors were encountered: