Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document deployment infrastructure #20

Open
tkphd opened this issue Apr 1, 2021 · 7 comments
Open

document deployment infrastructure #20

tkphd opened this issue Apr 1, 2021 · 7 comments

Comments

@tkphd
Copy link
Member

tkphd commented Apr 1, 2021

Strange that build-and-deploy.yml uses gh-pages, not the default main branch where edits go.

- name: Build and deploy gh-pages branch

Apparently, this is correct (see below), and necessary because this is not a vanilla deployment (i.e., not hosted by GitHub).

@ocaisa
Copy link
Member

ocaisa commented Apr 1, 2021

Yes, this action allows us to do the complicated build processes that are not allowed by vanilla GitHub pages, the action takes the main branch, builds it and then deploys it to gh-pages

@tkphd
Copy link
Member Author

tkphd commented Apr 1, 2021

Okaaay... what "complicated build processes" are we up to, and are they necessary?

@ocaisa
Copy link
Member

ocaisa commented Apr 1, 2021

You need to talk to me about 6 months ago when this information was on the tip of my tongue

@reid-a
Copy link
Member

reid-a commented Apr 1, 2021

Amend this issue to "document this workflow"?

@ocaisa
Copy link
Member

ocaisa commented Apr 1, 2021

I think it has something to do with queries to the GitHub repos and the use of json files

@ocaisa
Copy link
Member

ocaisa commented Apr 1, 2021

Carpentries should know, they do not deploy via GitHub because of these requirements

@ocaisa
Copy link
Member

ocaisa commented Apr 1, 2021

It's because of jekyll-get-json, see a3a475f for a little context

@tkphd tkphd changed the title build main, not gh-pages? document deployment infrastructure Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants