Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail work to validate feeds! #1

Open
vsoch opened this issue Jan 17, 2023 · 15 comments
Open

Detail work to validate feeds! #1

vsoch opened this issue Jan 17, 2023 · 15 comments

Comments

@vsoch
Copy link
Contributor

vsoch commented Jan 17, 2023

Currently - I have rough drafts of feeds with (known) missing fields or otherwise invalid. I just need to fix these (and then I think they should show up, and the ics file / ical feed should be usable. Just ran out of steam today :)

@alansill
Copy link
Contributor

I tried subscribing to the overall events listing in my Apple Calendar using the ical URL. I see multiple instances of each event listed, not sure why.
Screenshot 2023-01-26 at 4 00 08 PM
Screenshot 2023-01-26 at 4 01 50 PM

@alansill
Copy link
Contributor

BTW If we are going to have more than one choice of calendar event type we should probably separate them completely from each other so that people can decide which one(s) to subscribe to without potentially duplicating events if they subscribe to more than one calendar. (In the above case I only subscribed to the overall events one to keep things clean for testing.)

@vsoch
Copy link
Contributor Author

vsoch commented Jan 26, 2023

Yeah I'm not sure how to best debug this - when I tried adding to Google calendar I didn't see it show up at all. I was hoping someone else can take a look I'm quite busy atm.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 26, 2023

As a sanity check I'd look at the feed file and see that we aren't actually adding it multiple times!

@alansill
Copy link
Contributor

Yes, that's certainly the problem. We'll need to deduplicate the entries somehow and/or allow for editing of the list.

Presumably we're going to embed a calendar for display in the page for this on the web site. I can make one in our hpc.social GSuite for this purpose if needed, associated with some utility account, and we'll need to set up a subscription in that for the entries. Need to figure out the cause-and-effect -- is the idea that the list from the form would be turned into a susription link that anyone could add, or that it would be fed to a GSuite-based calendar that people could then use to subscribe to rather than the direct output from the form? Having an actual calendar -- perhaps there's a shared calendar feature in Google Calendar we could set up, I'll have to look into that -- could provide an intermediate point for editing perhaps and then people could subscribe to that calendar.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 26, 2023

@alansill I generate that file programmatically, if there are repeats there is a bug! Can you share a screenshot please?

@vsoch
Copy link
Contributor Author

vsoch commented Jan 27, 2023

And @alansill we already have a calendar that receives this feed, I guess you haven't looked :) https://hpc.social/events/

@alansill
Copy link
Contributor

@alansill I generate that file programmatically, if there are repeats there is a bug! Can you share a screenshot please?

$ grep -n -C2 NAME:Container all.ical
29- ork
30-LOCATION:virtual
31:NAME:Container Plumbing 2023
32-END:VEVENT
33-BEGIN:VEVENT

54- ork
55-LOCATION:virtual
56:NAME:Container Plumbing 2023
57-END:VEVENT
58-BEGIN:VEVENT

79- ork
80-LOCATION:virtual
81:NAME:Container Plumbing 2023
82-END:VEVENT
83-BEGIN:VEVENT

104- ork
105-LOCATION:virtual
106:NAME:Container Plumbing 2023
107-END:VEVENT
108-BEGIN:VEVENT

129- ork
130-LOCATION:virtual
131:NAME:Container Plumbing 2023
132-END:VEVENT
133-BEGIN:VEVENT

154- ork
155-LOCATION:virtual
156:NAME:Container Plumbing 2023
157-END:VEVENT
158-BEGIN:VEVENT

179- ork
180-LOCATION:virtual
181:NAME:Container Plumbing 2023
182-END:VEVENT
183-END:VCALENDAR

@alansill
Copy link
Contributor

And @alansill we already have a calendar that receives this feed, I guess you haven't looked :) https://hpc.social/events/

Didnʻt know it was live yet, I thought we were still testing.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 27, 2023

Well I put a lot of work into getting us most of the way there with the web interface - that was non-trivial to figure out. And the above just looks like a bug with figuring out when an event is repeated, which I'm actually fairly happy about.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 27, 2023

I haven't made any kind of announcement, so you can consider it still in testing. I was hoping someone would be able to help out, but maybe not.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 27, 2023

okay just pushed a fairly simple fix - instead of reading in an existing file, we just re-generate the whole thing each time.

@alansill
Copy link
Contributor

Thanks. Swamped this week-this is the best I could manage.

@vsoch
Copy link
Contributor Author

vsoch commented Jan 27, 2023

yeah no worries! Let's pick up on in the not too distant future when stuffs dies down :)

@vsoch
Copy link
Contributor Author

vsoch commented Apr 25, 2023

Good to close here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants