Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files in lookups/ and local/ #5

Open
jrstear opened this issue Jul 22, 2013 · 0 comments
Open

files in lookups/ and local/ #5

jrstear opened this issue Jul 22, 2013 · 0 comments
Labels

Comments

@jrstear
Copy link

jrstear commented Jul 22, 2013

the job macro depends on the existence of the cray lookup, which is currently a stub file in lookups/cray.csv. however when the app is installed somewhere and the cray.csv is updated appropriately, will it be overwritten next time the app is upgraded?

similarly, there is a local/sysnames.savedsearch file, which shouldn't cause problems, but nothing should be distributed in local/. it could just be put in a different directory.

the real fix is probably to have a config page which a site can use to tailor its config files according to its needs. e.g. does it have a cray, then click here to indicate you have updated the cray.csv lookup file (which the app with then confirm, and revise the job(3) lookup to use it, otherwise the job macro probably should not have it in there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant