Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml_config? #538

Closed
vsoch opened this issue Sep 16, 2022 · 8 comments
Closed

yaml_config? #538

vsoch opened this issue Sep 16, 2022 · 8 comments

Comments

@vsoch
Copy link
Contributor

vsoch commented Sep 16, 2022

Hi! I'm not sure if I'm missing something, but it says that yaml_config is required, but I don't see it in requirments.txt and the linked repository is 404 https://github.com/lanl/yaml_config. Is this the right repository for the Pavilion testing framework? I'm looking to develop for it and add a new scheduler / executor. Thanks!

@vsoch
Copy link
Contributor Author

vsoch commented Sep 16, 2022

This seems to be the library from: https://github.com/lanl-preteam/yaml_config. However the install deps script is forcing the user to create a venv, and then it's creating a bunch of dead symbolic links to its own lib directory. I'm confused because either we can use pip (and install to our preference of Python) or there is an approach like spack takes (and we do not use pip). When I write my own install routine to be able to use my preferred python, I hit #539. Thanks!

@Paul-Ferrell
Copy link
Collaborator

The symlinks in lib always exist whether you run bin/setup_pav_deps or not, and regardless of what mode you run it in. They won't hurt anything if they're dead. I should drop a README in there that explains that.

Running the bin/setup_pav_deps script should also pull down the correct yaml_config module, and install it appropriatly.

Alternatively, if you clone the Pavilion repo with git and run bin/setup_pav_deps, it will just get all those dependencies as git submodules.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 19, 2022

Thanks @Paul-Ferrell ! I did eventually figure it out but I ran into #539. Also, the links in the doc to yaml_config are broken so it might help to fix that.

For install, I think it would be good to either:

  1. Don't use pip and install things locally and manually, or
  2. Allow using pip

It's kind of confusing (and comes out at least looking like it's broken) to simultaneously take both approaches.

@Paul-Ferrell
Copy link
Collaborator

I have a unittest that's supposed to check for bad links in the docs, but github doesn't return a 404 for bad links...
I've fixed that in the #540 PR, which is now merged.

The pip setup is a bit broken. I really need to bring yaml_config directly into the Pavilion source, which will allow all the dependencies to be installed via pip. I'll do that before the next release. Thanks!

@vsoch
Copy link
Contributor Author

vsoch commented Sep 19, 2022

Awesome thank you!

@Paul-Ferrell
Copy link
Collaborator

I've been told you guys are working on setting up a Flux scheduler plugin for Pavilion. Scheduler plugins are a bit complicated - let me know if you want a run-down of how they work or any other sort of help. I'm on the Spack Slack and on DOE Mattermost.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 19, 2022

Sure thing! I indeed am doing exactly that - I will ping you if/when I run into trouble! I figure if i hit bugs I should report them here because others might too.

@Paul-Ferrell
Copy link
Collaborator

Made a separate ticket for moving in yaml_config. #543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants