Add basic support for WCS pixelization. #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
force-pushed
the
toast3_wcs
branch
2 times, most recently
from
ae00caa
to
09c0eb2
Compare
|
The unit test failures on MacOS are reproducible (a segfault inside the lapack routines of the Apple accelerate framework), but I have not tracked down what is triggering them. In addition to the standard WCS projections added to this PR, the pixels class now supports specifying a shared data object containing the variable Lon/Lat center of the projection. This allows us to make maps in source-centered coordinates. As an example, here are some plots from the unit tests showing the same data with a moving point source. One map was made in fixed RA/DEC coordinates and the other specified the fake source ephemeris as the center offset: |
* Add a new PixelsWCS operator * Add support for source-centered projection * Add ScanWCSMap and ScanWCSMask operators * Add I/O routines * Add unit tests for use of projections in mapmaking Currently this work adds a dependency on pixell, which is used only to build the WCS parameters. This is something we could implement internally if needed. For example, if we want to support more architectures than are currently supported by pixell binary wheels.
when autoscaling. Several unrelated small fixes.
keskitalo
reviewed
Jun 10, 2022
keskitalo
approved these changes
Jun 10, 2022
…d make apple lapack happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new PixelsWCS operator
Add I/O routines
Add unit tests for a couple of projections
Currently this work adds a dependency on pixell, which is used
only to build the WCS parameters. This is something we could
implement internally if needed. For example, if we want to
support more architectures than are currently supported by
pixell wheels.