You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Like Huggingface GPT2 Model, prepare_inputs_fn and update_model_kwargs_fn should be passed to generate. But in that code, these functions are not applied because _set_default_generate_kwargs() is called after super().__init__()
So, I think the order of call should be changed.
Environment
No response
The text was updated successfully, but these errors were encountered:
But when super().__init__() is calling, all keyword arguments are unpacked and passed to the super class. So, I think modifying the arguments will not propagate to super class.
馃悰 Describe the bug
generate_kwargs
is not properly passed toPPOTrainer
. So, generating sentences might be incorrect. (At leat in my case)ColossalAI/applications/ChatGPT/chatgpt/trainer/ppo.py
Lines 64 to 76 in 5d5f475
Like Huggingface GPT2 Model,
prepare_inputs_fn
andupdate_model_kwargs_fn
should be passed to generate. But in that code, these functions are not applied because_set_default_generate_kwargs()
is called aftersuper().__init__()
So, I think the order of call should be changed.
Environment
No response
The text was updated successfully, but these errors were encountered: