Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: ZeRO checkpoint would change the offload behavior #4528

Closed
Gy-Lu opened this issue Aug 28, 2023 · 0 comments · Fixed by #4529
Closed

[BUG]: ZeRO checkpoint would change the offload behavior #4528

Gy-Lu opened this issue Aug 28, 2023 · 0 comments · Fixed by #4529
Labels
bug Something isn't working

Comments

@Gy-Lu
Copy link
Contributor

Gy-Lu commented Aug 28, 2023

🐛 Describe the bug

In the current code, there is a lack of processing for offload when comes to checkpoints.
For example, with offload, the device of optimizer state should be CPU, which leads to an error when comm.

Besides, when loading the checkpoint, the device of the optimizer state should follow the original one rather than the loaded one. However, now it's just the opposite.

Environment

No response

@Gy-Lu Gy-Lu added the bug Something isn't working label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant