Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider versioning the extracted directory for the release tarball #2215

Closed
jscook2345 opened this issue Oct 10, 2018 · 8 comments · Fixed by #6029
Closed

consider versioning the extracted directory for the release tarball #2215

jscook2345 opened this issue Oct 10, 2018 · 8 comments · Fixed by #6029
Assignees
Milestone

Comments

@jscook2345
Copy link
Contributor

Version of Singularity:

3.0.0

Expected behavior

curl -LO https://github.com/sylabs/singularity/releases/download/v3.0.0/singularity-v3.0.0.tar.gz
tar -xzf singularity-v3.0.0.tar.gz
ls singularity-3.0.0

Actual behavior

curl -LO https://github.com/sylabs/singularity/releases/download/v3.0.0/singularity-v3.0.0.tar.gz
tar -xzf singularity-v3.0.0.tar.gz
ls singularity

Several users in the FOSS slack requested this for a few reasons:

  • Most common practice.
  • Easier to make RPMs / system packages.
@jmstover
Copy link
Contributor

I believe @yhcote already has a fix in the works for this to get around my quick hack to get a make dist target in place before release.

@tri-adam
Copy link
Contributor

Just to be clear, in order to successfully build the Go source, the source must be present in src/github.com/sylabs/singularity within the Go workspace. We can make the tarball whatever folks prefer, but it will need to be mved to the appropriate place. That's a Go limitation (see https://golang.org/doc/code.html for an explanation.)

@bauerm97
Copy link
Contributor

Agree with @tri-adam here, this isn't something we wish to change to be honest. This is a byproduct of Golang

@dtrudg
Copy link
Contributor

dtrudg commented Sep 20, 2019

With go modules - is this something to reconsider since we can have the source in a directory named for the version?

@jscook2345
Copy link
Contributor Author

@mem

Thoughts?

@dtrudg dtrudg unassigned mem May 12, 2020
@dtrudg dtrudg added this to the 3.8.0 milestone Mar 9, 2021
@dtrudg
Copy link
Contributor

dtrudg commented Mar 9, 2021

Marking for 3.8. No reason not to do this no we are on non-GOPATH go modules for some time.

@carterpeel
Copy link
Contributor

Hello,

This is a templated response that is being sent out to all open issues. We are working hard on 'rebuilding' the Singularity community, and a major task on the agenda is finding out what issues are still outstanding.

Please consider the following:

  1. Is this issue a duplicate, or has it been fixed/implemented since being added?
  2. Is the issue still relevant to the current state of Singularity's functionality?
  3. Would you like to continue discussing this issue or feature request?

Thanks,
Carter

@jscook2345 jscook2345 removed their assignment May 17, 2021
@DrDaveD DrDaveD assigned DrDaveD and unassigned jmstover Jun 7, 2021
@DrDaveD
Copy link
Collaborator

DrDaveD commented Jun 7, 2021

This is still relevant, and in fact Sylabs implemented it for their 3.8.0 in their pr 25. Also see changes they made to the rpm spec in their pr 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants