modeller easyblock #392
Merged
modeller easyblock #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from easybuild.framework.easyblock import EasyBlock | ||
| from easybuild.tools.filetools import run_cmd_qa | ||
| from easybuild.framework.easyconfig import CUSTOM |
There was a problem hiding this comment.
put these in alphabetical order
|
Looks good |
| def extra_options(): | ||
| """Add extra easyconfig parameters custom to Modeller""" | ||
| extra_vars = { | ||
| 'LICENSEKEY': ["", "Specify the modeller license key", CUSTOM], |
There was a problem hiding this comment.
hmm, I would rather like to see this as a generic easyconfig parameter license_key, next to the existing license_file and license_server, since it's a generic concept
There was a problem hiding this comment.
I don't know exactly what you mean...
There was a problem hiding this comment.
we should add license_key as an available easyconfig parameter in framework, rather than doing it only here in this easyblock...
|
@pescobar: ping on these remarks? |
|
@pescobar: ping wrt resolving remarks? |
|
@boegel I will take a look at this on monday |
add copyright/license header, use license_key easyconfig parameter
use existing 'key' easyconfig parameter
|
tested with easybuilders/easybuild-easyconfigs#825, looking excellent now, going in Thanks @pescobar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.