Use *buildopts instead of *makeopts in configuremake & pythonpackage #427
Conversation
|
@wpoely86: why limit yourself to only these two easyblocks? ;-) Replacements like this should be safe since EasyBuild v1.13, this will still work even if the easyconfig only defines |
|
@boegel at your request, this is the result of |
| @@ -217,7 +217,7 @@ def post_install_step(self): | |||
| cmd = "make -f makefile libintel64 %s" % extramakeopts | |||
|
@wpoely86: nice, thanks. One tiny remark. Are you up for also doing this in the easyconfigs repo? That we, we should be able to rebuild all of the ones being touched there using this easyblocks branch and upload a test report in the easyconfigs PR, just to make sure we're not breaking anything (should be fine, but we better make sure). |
|
@boegel Sure, no problem. But should we wait with that PR until the merge windows closes? Then we're sure to have everything? |
|
@wpoely86: I plan to make the easyconfig unit tests capture any use of |
|
@wpoely86: merge with develop is broken, please fix (I want to get this in for EasyBuild v1.14, postponing this further will be a pain) |
* develop: fix remark icc: change point when to drop idb fix remarks include --ignorearch when installing rebuilt RPMs don't try to enforce x86_64 build arch when rebuilding rpms fix poor mans version of toolchain compiler detection in imkl easyblock icc: idb is deprecated fix typo enhance BLAT easyblock by using super's build_step and prebuildopts/buildopts add easyblock for HPCG Conflicts: easybuild/easyblocks/b/blat.py easybuild/easyblocks/i/imkl.py
|
@boegel ready for merge |
|
@wpoely86: reviewed (again), and ran a few tests, looking great, so going in. thanks! |
Use *buildopts instead of *makeopts in configuremake & pythonpackage
Get rid of the deprecated warnings.