Easyblocks for R extenison patching (including extract) and Extesnion Rm... #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Rmpi Intel MPI support (if version >= 0.6-4)
|
Automatic reply from Jenkins: Can I test this? |
|
ok to test |
| if self.patches: | ||
| cmd = "R CMD INSTALL %s %s %s %s --no-clean-on-error" % (self.ext_dir, confargs, confvars, prefix) | ||
| else: | ||
| cmd = "R CMD INSTALL %s %s %s %s --no-clean-on-error" % (self.ext_src, confargs, confvars, prefix) |
There was a problem hiding this comment.
the cmd value is exactly the same in both cases?!
There was a problem hiding this comment.
Look at more close!
cmd = "R CMD INSTALL %s %s %s %s --no-clean-on-error" % (self.ext_dir, confargs, confvars, prefix)
and
cmd = "R CMD INSTALL %s %s %s %s --no-clean-on-error" % (self.ext_src, confargs, confvars, prefix)
There was a problem hiding this comment.
Maybe split up the command and the tuple then? The cmd string itself is the same?
There was a problem hiding this comment.
Yeah, exactly. Suggestion:
if self.patches:
loc = self.ext_dir
else:
loc = self.ext_src
cmd = "R CMD INSTALL %s %s %s %s --no-clean-on-error" % (loc, confargs, confvars, prefix)
|
Updated with comments. |
| @@ -46,12 +47,19 @@ def run(self): | |||
| toolchain.MPI_TYPE_MPICH: "MPICH", | |||
| #toolchain.MPI_TYPE_LAM: "LAM", # no support for LAM yet | |||
| } | |||
| # type of MPI | |||
| # MPI_TYPE does not distinguish between MPICH and MPI, which is why we also check mpi_family() | |||
|
Typos and style corrected |
added 2 commits
September 10, 2014 09:43
Author name added
Author added
|
Tested with easybuilders/easybuild-easyconfigs#1077, working great, so going in. Thanks @hajgato! |
boegel
added a commit
that referenced
this pull request
Sep 10, 2014
…ntel-2014b Easyblocks for R extenison patching (including extract) and Extesnion Rm...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...pi Intel MPI support (if version >= 0.6-4)