Easyblock for MCR (REVIEW) #623
Conversation
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1014/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1016/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@hajgato: is this still WIP? If so, please mark it in the subject. |
|
@boegel :) |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1147/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
|
||
| txt = super(EB_MCR, self).make_module_extra() | ||
|
|
||
| txt += self.module_generator.set_environment('XAPPLRESDIR', os.path.join(self.installdir, self.extradir[self.cfg['version']], 'X11', 'app-defaults')) |
There was a problem hiding this comment.
@hajgato: please introduce a variable for the extradir, and fetch the value in a way that it's 'safe' in case the version is not known yet; also, use self.version rather than self.cfg['version']
extradir = self.extradir.get(self.version, 'UNKNOWN')There was a problem hiding this comment.
hmm, I do not understand it. The self.version would be something like R2015b,and the extradir should be v86 or something. Should we directly define extradir in the easyconfig file?
There was a problem hiding this comment.
It's OK to make the mapping from version to subdir in the easyblock, but to make this easyblock compatible with --module-only and avoid hard crashes if a new version is attempted, use self.extradir.get rather than self.extradir[..]
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1151/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1152/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1153/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
fix syntax error & sync with develop
|
Refer to this link for build results (access rights to CI server needed): See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1155/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
avoid having to hardcode version-specific subdirs + style fixes
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Tested with easybuilders/easybuild-easyconfigs#1677, working as intended. Going in, thanks @hajgato! |
No description provided.