use --with-tcltk* configure options to point to ensure Tcl/Tk deps are picked up #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1330/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| @@ -104,6 +104,26 @@ def configure_step(self): | |||
| line = re.sub(r"^#(\s*-L\$\(SSL\)/lib )", r"\1 -L$(SSL)/lib64 ", line) | |||
| sys.stdout.write(line) | |||
|
|
|||
| tcl = get_software_root('Tcl') | |||
| tk = get_software_root('Tk') | |||
| if tcl and tk: | |||
There was a problem hiding this comment.
People are free to use the system Tcl/Tk (e.g. by suing --filter-deps), which is fine.
|
lgtm |
This was referenced Oct 29, 2015
|
Testing confirms that this fixes the (original) issue reported in #728. |
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Oct 29, 2015
use --with-tcltk* configure options to point to ensure Tcl/Tk deps are picked up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #728