Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libxml2 when not available from OS #765

Merged
merged 6 commits into from Dec 11, 2015
Merged

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Dec 10, 2015

This only worked initially because setup.py found the libxml headers from the system. When these are not available the installation fails.

Also need to explicitly tell the configure not to build the python bindings itself (otherwise it will try to install them as an extension to the python it finds and you might not have permission there...and it's also not what you want).

Alan added 3 commits December 10, 2015 17:10
…from the system. When they are not available the installation fails.

Also need to explicitly tell the configure not to build the python bindings itself (otherwise it will try to install them as an extension to the python it finds and you might not have permission there)
@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@ocaisa
Copy link
Member Author

ocaisa commented Dec 10, 2015

@JensTimmerman You might want to review this

@JensTimmerman
Copy link
Contributor

jenkins: ok to test

@JensTimmerman
Copy link
Contributor

Looks fine to me, I have no idea why this worked for me then, since I don't have permission to install things in the system python.

@ocaisa
Copy link
Member Author

ocaisa commented Dec 10, 2015

I ran into a problem because someone else (actually me by another name) had installed the Python dep. It tried to install the modules there by default, I only got around it by explicitly switching the bindings off for the configure.

@hpcugentbot
Copy link
Contributor

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1455/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Dec 10, 2015

@ocaisa: should the sanity check be enhanced to catch this problem, i.e. to check that the Python bindings are available from the libxml2 install prefix?

@boegel boegel added this to the v2.5.0 milestone Dec 10, 2015
@ocaisa
Copy link
Member Author

ocaisa commented Dec 11, 2015

Done, also checked that the expected happens when someone manually adds --with-python in the easyconfig - --without-python added in the block takes precedence (as expected)

@hpcugentbot
Copy link
Contributor

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1465/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Dec 11, 2015

Thoroughly tested with existing libxml2 easyconfigs, works like a charm, thanks @ocaisa!

boegel added a commit that referenced this pull request Dec 11, 2015
Libxml2 when not available from OS
@boegel boegel merged commit fe72b53 into easybuilders:develop Dec 11, 2015
@ocaisa ocaisa deleted the libxml2 branch December 15, 2015 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants