Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also define $LD in buildopts for GATE #855

Merged
merged 3 commits into from Mar 4, 2016
Merged

also define $LD in buildopts for GATE #855

merged 3 commits into from Mar 4, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 4, 2016

No description provided.

@boegel boegel added this to the v2.7.0 milestone Mar 4, 2016
@boegel boegel mentioned this pull request Mar 4, 2016
Merged
@hpcugentbot
Copy link
Contributor

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1749/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

wpoely86
wpoely86 reviewed Mar 4, 2016
View reviewed changes
easybuild/easyblocks/g/gate.py
# filemerger Makefile hardcodes $LD to g++, so make sure right compiler is used for linking
'LD': os.getenv('CXX'),
}
make_opts = 'CC="%(CC)s" CFLAGS="%(CFLAGS)s" CXX="%(CXX)s" CXXFLAGS="%(CXXFLAGS)s" LD="%(LD)s"' % opt_vals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be done nicer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better now?

boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Mar 4, 2016
@boegel
$LD is set correctly in GATE easyblock, so remove from easyconfig (cfr.
cd3f12a 
easybuilders/easybuild-easyblocks#855)
@hpcugentbot
Copy link
Contributor

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1750/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Member

wpoely86 commented Mar 4, 2016

👍

@hpcugentbot
Copy link
Contributor

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1752/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 4, 2016

testing with all existing GATE easyconfigs + the ones in easybuilders/easybuild-easyconfigs#2623, works like a charm now, so going in

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Mar 4, 2016
@boegel
Merge pull request #855 from boegel/gate_fix_make_opts
581c6ce 
also define $LD in buildopts for GATE
@boegel boegel merged commit 581c6ce into easybuilders:develop Mar 4, 2016
@boegel boegel deleted the gate_fix_make_opts branch March 4, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boegel @hpcugentbot @wpoely86