Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[goolf/1.4.10] Cufflinks 1.3.0 (REVIEW) #1343

Merged
merged 4 commits into from May 31, 2015

Conversation

rjeschmi
Copy link
Contributor

Some users haven't migrated to Cufflinks 2, so here is 1.3.0 (newest version 1). Somewhat old, but users want it.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

('zlib', '1.2.7'),
]

patches = ['Cufflinks_GCC-4.7.patch', 'cufflinks-1.3.0-ldflags.patch']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each patch on a single line please, use %(version)s rather than hardcoding 1.3.0

@boegel
Copy link
Member

boegel commented Jan 27, 2015

Jenkins: ok to test

@rjeschmi
Copy link
Contributor Author

I renamed the patch since I'm pretty sure it is a general Cufflinks-1 issue (though there may never be another version...)

@hpcugentbot
Copy link
Contributor

Test PASSed.

2 similar comments
@hpcugentbot
Copy link
Contributor

Test PASSed.

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member

boegel commented May 31, 2015

Jenkins: test this please

@boegel
Copy link
Member

boegel commented May 31, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c93f1747de3d8bf473a8 for a full test report.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3189/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3189/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented May 31, 2015

Going in, thanks @rjeschmi!

boegel added a commit that referenced this pull request May 31, 2015
{bio}[goolf/1.4.10] Cufflinks 1.3.0  (REVIEW)
@boegel boegel merged commit 6123189 into easybuilders:develop May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants