Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio,devel} [foss/2015a] Cufflinks 2.2.1 (REVIEW) #1351

Merged
merged 3 commits into from May 31, 2015

Conversation

rjeschmi
Copy link
Contributor

No description provided.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@rjeschmi rjeschmi changed the title a foss-2015a version of Cufflinks-2.2.1 {bio,devel} [foss/2015a] Cufflinks 2.2.1 (REVIEW) Jan 29, 2015
# issues with boost > 1.55, see https://github.com/cole-trapnell-lab/cufflinks/issues/3
('Boost', '1.55.0', '-Python-2.7.9'),
('SAMtools', '0.1.19'),
('Eigen', '3.2.3'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.2.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just sticking with the same version as intel-2015a, we could move them both forward if it makes sense...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's stick with 3.2.3.

@wpoely86
Copy link
Member

ok to test

@hpcugentbot
Copy link
Contributor

Test PASSed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2485/
Test PASSed.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2486/
Test PASSed.

# issues with boost > 1.55, see https://github.com/cole-trapnell-lab/cufflinks/issues/3
('Boost', '1.51.0', '-Python-2.7.3'),
('SAMtools', '0.1.18'),
('Eigen', '3.1.1'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these versions are quite different from the ones in the foss/2015a easyconfig?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are consistent with the versions for goolf-1.4.10 and tied to version of samtools used in tophat (and deps there).

I had a user recently load both the foss-2015a version of cufflinks and the goolf-1.4.10 version of tophat and have trouble.

And before you ask, tophat can't be compiled against GCC-4.9 (yet?)...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually keep dependency versions consistent across easyconfigs for the same software version (Cufflinks), across toolchains...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deps in the foss/2015a easyconfig contributed here match the ones in the existing one for intel/2015a, so just align them accordingly here too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: try and keep your users from mixing toolchains, that's a big bag of worms...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll just kick the 1.4.10 version out since it isn't high priority

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rjeschmi
Copy link
Contributor Author

rjeschmi commented Mar 5, 2015

removed a commit

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/2488/
Test PASSed.

@rjeschmi
Copy link
Contributor Author

rjeschmi commented Mar 6, 2015

Test report by @rjeschmi
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
Linux centos 6.6, Intel(R) Xeon(R) CPU E5440 @ 2.83GHz, Python 2.6.6
See https://gist.github.com/7b7fcaea6f5ac602ebbe for a full test report.

@rjeschmi
Copy link
Contributor Author

rjeschmi commented Mar 6, 2015

Test report by @rjeschmi
SUCCESS
Build succeeded for 9 out of 9 (4 easyconfigs in this PR)
Linux centos 6.6, Intel(R) Xeon(R) CPU E5440 @ 2.83GHz, Python 2.6.6
See https://gist.github.com/9c8e8c0cad4bc657f6d0 for a full test report.

@rjeschmi
Copy link
Contributor Author

rjeschmi commented Mar 6, 2015

The second report includes everything that is on top of the base foss-2015a install (which is why it is a bit bigger).

@rjeschmi
Copy link
Contributor Author

@boegel I'm pretty sure all the URLs got fixed earlier this year:

https://github.com/hpcugent/easybuild-easyconfigs/pull/1335/files

@boegel
Copy link
Member

boegel commented May 31, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3190/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3190/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented May 31, 2015

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6edca661e65692fbee3f for a full test report.

@boegel
Copy link
Member

boegel commented May 31, 2015

No reason to hold this back any further, thanks @rjeschmi (and @wpoely86 for the review)!

boegel added a commit that referenced this pull request May 31, 2015
{bio,devel} [foss/2015a] Cufflinks 2.2.1 (REVIEW)
@boegel boegel merged commit 7d95682 into easybuilders:develop May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants