Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[dummy] fastqc 0.11.2 + 0.11.3 #1636

Merged
merged 1 commit into from May 27, 2015
Merged

{bio}[dummy] fastqc 0.11.2 + 0.11.3 #1636

merged 1 commit into from May 27, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented May 27, 2015

No description provided.

@boegel
Copy link
Member Author

boegel commented May 27, 2015

@ehiggs: please review

@boegel
Copy link
Member Author

boegel commented May 27, 2015

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/5d5d88cf32732c4d5853 for a full test report.

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3109/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3109/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented May 27, 2015

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b25c6fa7a38e41e1f7a3 for a full test report.

ehiggs
ehiggs reviewed May 27, 2015
View reviewed changes
easybuild/easyconfigs/f/fastqc/fastqc-0.11.3.eb

dependencies = [('Java', '1.7.0_80')]

postinstallcmds = ["chmod -R a+rx %(installdir)s/fastqc %(installdir)s/run_fastqc.bat"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using linux commands to make windows scripts executable?

@ehiggs
Copy link
Contributor

ehiggs commented May 27, 2015

+1 merge it

@boegel
Copy link
Member Author

boegel commented May 27, 2015

Thanks for the review @ehiggs !

boegel added a commit that referenced this pull request May 27, 2015
@boegel
Merge pull request #1636 from boegel/fastqc
739a81e 
{bio}[dummy] fastqc 0.11.2 + 0.11.3
@boegel boegel merged commit 739a81e into easybuilders:develop May 27, 2015
@boegel boegel deleted the fastqc branch May 27, 2015 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boegel @hpcugentbot @ehiggs