New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEEF 0.1.1-r16 + rename libbeef to BEEF #1679
Conversation
Automatic reply from Jenkins: Can I test this? |
Yes. |
Jenkins: ok to test |
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4510/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@valtandor: I recently created an easyconfig for this too, which was merged a while ago, see #1827 There are a couple of differences: I went with It would be nice to sync up these easyconfigs in one way or another... Thoughts? |
@boegel: I have updated the home page and description, and gone with the name BEEF as it seems to be the official name of the whole package itself (the tarball name notwithstanding). Comments have been provided in lieu of source_urls where the source code was built from an SVN checkout. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4634/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
toolchain = {'name': 'iomkl', 'version': '4.6.13'} | ||
toolchainopts = {'openmp': False, 'usempi': False} | ||
|
||
# There is no source_url as this version is built from a tarred SVN checkout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe include the SVN repo URL?
and also thesvn
command one can use to check out this exact version?
you'll need to fix the easyconfig filename here too, the versions don't match up
@valtandor: I'm OK with going with BEEF, I wasn't quite sure when I went with |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4741/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
#for url in source_urls: | ||
# svn co -r 16 url | ||
# tar --exclude-vcs -cjvf "beef-0.1.1-r16.tar.bz2" "beef" | ||
#sources = [SOURCELOWER_TAR_BZ2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valtandor: you probably meant to uncomment the source_urls
, and leave sources
as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure. Does Easybuild allow for checking out SVN sources directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not yet. This is in the works, but it has been dormant for a while, see easybuilders/easybuild-framework#1082.
So, for now, you need to create the tarball manually, and only specify sources
(together with some comments on how to create the source tarball, like you did here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will do, when I have a moment and am not working on a file in another branch.
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4844/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
toolchainopts = {'openmp': False, 'usempi': False} | ||
|
||
source_urls = ['https://confluence.slac.stanford.edu/download/attachments/146704476'] | ||
sources = "libbeef-{0}.tar.gz".format(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a list, and please use %(version)s
(avoid using Python code when you can in easyconfigs)
sources = ['libbeef-%(version)s.tar.gz']
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4856/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
||
# To make a source tarball from the SVN repository: | ||
# 1. svn co -r 16 svn://suncatls1.slac.stanford.edu/beef | ||
# 2. tar --exclude-vcs -cjvf beef-0.1.1-r16.tar.bz2 beef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two issues I ran into when testing this:
- my
tar
does not support--exclude-vcs
; it does support using--exclude \.svn
, maybe that's more generic? - you should tar
beef/trunk
, notbeef
right? if not, I run into the problem thatconfigure
is not found during the EB run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, my suggestion:
2. tar --exclude \.svn -cjvf beef-0.1.1-r16.tar.bz2 beef/trunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about tar --exclude \.svn --transform 's,^beef/trunk,beef-0.1.1-r16,' -cjvf beef-0.1.1-r16.tar.bz2 beef/trunk
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion, but: tar: Option --transform is not supported
:-)
I wouldn't worry too much about how the top-level dir is called, since it only matters for the build dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Righto. My local repo is right now in a different branch, but once it's finished with that branch I'll make these changes and upload them.
Test report by @boegel |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4857/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Going in, thanks @valtandor! |
BEEF 0.1.1-r16 + rename libbeef to BEEF
New EasyConfigs for the BEEF library and binary.