Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEEF 0.1.1-r16 + rename libbeef to BEEF #1679

Merged
merged 11 commits into from Oct 27, 2015
Merged

Conversation

valtandor
Copy link
Contributor

New EasyConfigs for the BEEF library and binary.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@valtandor
Copy link
Contributor Author

Yes.

@boegel
Copy link
Member

boegel commented Jun 8, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3452/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3452/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestone: v2.2 Jun 24, 2015
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4510/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.4.0 milestone Sep 25, 2015
@boegel
Copy link
Member

boegel commented Sep 25, 2015

@valtandor: I recently created an easyconfig for this too, which was merged a while ago, see #1827

There are a couple of differences: I went with libbeef as name (it was not 100% clear to me what the official name was), you didn't include source_urls, I'm passing CC="$CC" to make sure the right compiler is being used, and the homepage/description is different

It would be nice to sync up these easyconfigs in one way or another... Thoughts?

@valtandor
Copy link
Contributor Author

@boegel: I have updated the home page and description, and gone with the name BEEF as it seems to be the official name of the whole package itself (the tarball name notwithstanding). Comments have been provided in lieu of source_urls where the source code was built from an SVN checkout. CC="$CC" has been included where appropriate. I hope this is OK.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4634/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

toolchain = {'name': 'iomkl', 'version': '4.6.13'}
toolchainopts = {'openmp': False, 'usempi': False}

# There is no source_url as this version is built from a tarred SVN checkout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe include the SVN repo URL?
and also thesvn command one can use to check out this exact version?

you'll need to fix the easyconfig filename here too, the versions don't match up

@boegel
Copy link
Member

boegel commented Oct 6, 2015

@valtandor: I'm OK with going with BEEF, I wasn't quite sure when I went with libbeef either, and I don't feel strongly about it, thanks for syncing things up!

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4741/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

#for url in source_urls:
# svn co -r 16 url
# tar --exclude-vcs -cjvf "beef-0.1.1-r16.tar.bz2" "beef"
#sources = [SOURCELOWER_TAR_BZ2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valtandor: you probably meant to uncomment the source_urls, and leave sources as is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure. Does Easybuild allow for checking out SVN sources directly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not yet. This is in the works, but it has been dormant for a while, see easybuilders/easybuild-framework#1082.

So, for now, you need to create the tarball manually, and only specify sources (together with some comments on how to create the source tarball, like you did here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will do, when I have a moment and am not working on a file in another branch.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4844/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

toolchainopts = {'openmp': False, 'usempi': False}

source_urls = ['https://confluence.slac.stanford.edu/download/attachments/146704476']
sources = "libbeef-{0}.tar.gz".format(version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a list, and please use %(version)s (avoid using Python code when you can in easyconfigs)

sources = ['libbeef-%(version)s.tar.gz']

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4856/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


# To make a source tarball from the SVN repository:
# 1. svn co -r 16 svn://suncatls1.slac.stanford.edu/beef
# 2. tar --exclude-vcs -cjvf beef-0.1.1-r16.tar.bz2 beef
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two issues I ran into when testing this:

  • my tar does not support --exclude-vcs; it does support using --exclude \.svn, maybe that's more generic?
  • you should tar beef/trunk, not beef right? if not, I run into the problem that configure is not found during the EB run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, my suggestion:

2. tar --exclude \.svn -cjvf beef-0.1.1-r16.tar.bz2 beef/trunk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about tar --exclude \.svn --transform 's,^beef/trunk,beef-0.1.1-r16,' -cjvf beef-0.1.1-r16.tar.bz2 beef/trunk?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion, but: tar: Option --transform is not supported :-)

I wouldn't worry too much about how the top-level dir is called, since it only matters for the build dir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Righto. My local repo is right now in a different branch, but once it's finished with that branch I'll make these changes and upload them.

@boegel
Copy link
Member

boegel commented Oct 27, 2015

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/fcf7c99aeb668b7f777d for a full test report.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4857/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Oct 27, 2015

Going in, thanks @valtandor!

@boegel boegel changed the title Beef BEEF 0.1.1-r16 + rename libbeef to BEEF Oct 27, 2015
boegel added a commit that referenced this pull request Oct 27, 2015
BEEF 0.1.1-r16 + rename libbeef to BEEF
@boegel boegel merged commit ca63e42 into easybuilders:develop Oct 27, 2015
@valtandor valtandor deleted the BEEF branch October 27, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants