Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also copy 'ext', set $PATH and $PYTHONPATH correctly for Stampy #2182

Merged
merged 2 commits into from Dec 3, 2015
Merged

also copy 'ext', set $PATH and $PYTHONPATH correctly for Stampy #2182

merged 2 commits into from Dec 3, 2015

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 3, 2015

overlooked in #2180

@boegel boegel added this to the v2.5.0 milestone Dec 3, 2015
@boegel
Copy link
Member Author

boegel commented Dec 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/13759df165522517a2dd for a full test report.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5127/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Dec 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/40a6cb760d4ac9eff5c1 for a full test report.

wpoely86
wpoely86 reviewed Dec 3, 2015
View reviewed changes
easybuild/easyconfigs/s/Stampy/Stampy-1.0.28-intel-2015b-Python-2.7.10.eb
'dirs': ['ext', 'plugins', 'Stampy'],
}

modextrapaths = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might add a comment why they are empty? Seems weird for new/external people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5128/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Dec 3, 2015

Thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Dec 3, 2015
@boegel
Merge pull request #2182 from boegel/stampy1028_intel2015b_py2710
56c6448 
also copy 'ext', set $PATH and $PYTHONPATH correctly for Stampy
@boegel boegel merged commit 56c6448 into easybuilders:develop Dec 3, 2015
@boegel boegel deleted the stampy1028_intel2015b_py2710 branch December 3, 2015 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boegel @hpcugentbot @wpoely86