Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed PrgEnv version, craype and fftw from the new Cray* XC toolchain (REVIEW) #2554

Merged
merged 3 commits into from Feb 27, 2016

Conversation

gppezzi
Copy link
Contributor

@gppezzi gppezzi commented Feb 23, 2016

This removes fftw (as discussed before) and also craype from the toolchain. I'm creating this PR to update with the latest results and to keep track of the discussion.

The craype removal was advised by Cray (they claim that craype is backwards compatible) as a fix for the bugs we were having when swapping (non-default) PrgEnv dependencies.

Ideally we want to pin versions for all the dependencies, but first I'd like to have a working TC and hopefully this version will work on more systems. For the moment this version works on Daint, Dora, Santis and Brisi (we still need to test on Swan and Sisu).

Here I've also removed the version from the PrgEnv and the other change required is to unload + load the PrgEnv instead of swapping. PR#??

This replaces #2442

@boegel boegel added this to the v2.7.0 milestone Feb 23, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6528/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 23, 2016

I did some more testing and this still hits the libsci problem on santis (nevermind, it is also working on santis)

@gppezzi gppezzi changed the title removed craype and fftw from the new Cray* XC toolchains {WIP} removed PrgEnv version, craype and fftw from the new Cray* XC toolchains {WIP} Feb 24, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6563/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Feb 24, 2016

@gppezzi: all descriptions mentions PrgEnv-gnu, please correct that

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6574/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 24, 2016

@boegel thx for the review, I've corrected that.

btw did I mention already that those files are not working because EB cannot load a module using the default version? :)

We can keep the versions pinned for now, if this is too complicated to change on the framework. Let me know.

(I've already cooked all the XC .ebs with the pinned PrgEnv version on our 4 systems, now i' m doing it on swan)

@boegel
Copy link
Member

boegel commented Feb 24, 2016

@gppezzi: this should fix your problem: easybuilders/easybuild-framework#1630

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.6
See https://gist.github.com/7c5cbd773874247904c2 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.9
See https://gist.github.com/513af926963f645973a6 for a full test report.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.9
See https://gist.github.com/888ef7e695474b3e60b4 for a full test report.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz, Python 2.7.7
See https://gist.github.com/678b7dd61ba6656bb303 for a full test report.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz, Python 2.7.7
See https://gist.github.com/29ebf02f7ca95c500223 for a full test report.

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
brisi101 - Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz, Python 2.7.7
See https://gist.github.com/2fd1891b639bf0bbcea9 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
sisu-login4 - Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.9
See https://gist.github.com/6b1aac29307f6cdc2e2a for a full test report.

@boegel
Copy link
Member

boegel commented Feb 26, 2016

rebuilding the existing HPL easyconfigs on top of these redefined toolchains works on Sisu

@gppezzi: please confirm on Daint/Dora/Santis/Brisi/Swan?

@gppezzi
Copy link
Contributor Author

gppezzi commented Feb 26, 2016

@boegel Just tested the new HPL EBs on Daint/Dora/Santis/Brisi/Swan and it all went well.

It looks like we're very close to first stable release for Cray 👍

@boegel boegel changed the title removed PrgEnv version, craype and fftw from the new Cray* XC toolchains {WIP} removed PrgEnv version, craype and fftw from the new Cray* XC toolchain (REVIEW) Feb 27, 2016
@boegel
Copy link
Member

boegel commented Feb 27, 2016

Extensively tested with the easyconfigs from #2434 and #2435, good to go.

Thanks for figuring this out @gppezzi!

boegel added a commit that referenced this pull request Feb 27, 2016
removed PrgEnv version, craype and fftw from the new Cray* XC toolchain (REVIEW)
@boegel boegel merged commit ccffbda into easybuilders:develop Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants