New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[dummy/] Reads2snp v2.0 #3609
{bio}[dummy/] Reads2snp v2.0 #3609
Conversation
sources = ['%(namelower)s_%(version)s.zip'] | ||
|
||
sanity_check_paths = { | ||
'files': ['reads2snp_2.0.64.bin'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pescobar use %(version)s
rather than hardcoding the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
} | ||
|
||
# disable exec permission for the provided 32 bits binary | ||
postinstallcmds = ['chmod -x %(installdir)s/reads2snp_%(version)s.32.bin'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, why? to prevent users from using the 32-bit version?
isn't this a site-specific customisation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
lgtm |
Test report by @boegel |
Going in, thanks @pescobar! |
(created using
eb --new-pr
)