Contrib ncview #728
Contrib ncview #728
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
@boegel I don't know why it didn't pass the test...it works fine on our cluster... |
|
Jenkins: test this please |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4309/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@wpoely86: please review |
tloizou
force-pushed
the
contrib_ncview
branch
from
b6623c9
to
5ee4425
Compare
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4327/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4331/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
looks ready to merge. |
|
@wpoely86: if you use to get a full 3/3 perfect score, the PR needs to pass the tests (ok here), needs an OK w.r.t. style, and needs a working test report |
|
lgtm |
| sanity_check_paths = { | ||
| 'files': ['bin/ncview'], | ||
| 'dirs': [], | ||
| } |
There was a problem hiding this comment.
@tloizou: missing moduleclass here
|
Test report by @boegel |
|
Test report by @boegel |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4427/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
going in, thanks @tloizou! |
Contributing ncview, a visual browser for netCDF format files.