{tools}[goolf/1.4.10,ictce/5.3.0] ncregrid 1.4b (REVIEW) #729
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
@boegel I don't know why it didn't pass the test...it works fine on our cluster... |
|
Jenkins: test this please |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4310/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@wpoely86: please review |
| @@ -0,0 +1,24 @@ | |||
| --- configure.orig 2014-02-13 15:25:53.464250437 +0200 | |||
There was a problem hiding this comment.
always add a comment on top about what the purpose of the patch is.
tloizou
force-pushed
the
contrib_ncregrid
branch
from
7be011e
to
4b8718f
Compare
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4328/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4329/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4330/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4386/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@boegel doesn't Jenkins run with the develop branch of the framework? |
minor style fixes
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4423/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| toolchainopts = {'optarch': True, 'usempi': True, 'pic': True} | ||
|
|
||
| source_urls = ['http://www.pa.op.dlr.de/~PatrickJoeckel/ncregrid/'] | ||
| sources = ['%(name)s.tar.Z'] |
There was a problem hiding this comment.
I'm running into this issue:
tar (child): compress: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
because compress (used by tar) is not available on the system...
adding compress as a build dep is probably wise, but this also requires that easybuilders/easybuild-framework#1376 gets fixed (which may be non-trivial to fix without introducing regressions elsewhere)
@wpoely86: are you up for taking a closer look at easybuilders/easybuild-framework#1376?
There was a problem hiding this comment.
I will have a look but this does not need to hold this PR back.
There was a problem hiding this comment.
I feel it does, since it's failing because of a missing (somewhat uncommon) dep
There was a problem hiding this comment.
yes, but the framework also needs an enhancement. It's minor IMHO.
There was a problem hiding this comment.
the very minimal would be to add osdependencies = ['compress'] here
but I prefer fixing this via a build dep instead, so yes, then it requires fixing easybuilders/easybuild-framework#1376
boegel
changed the title
|
@tloizou, this PR is being closed for the following reason(s): no activity for > 6 months. |
Contributing ncregrid, a tool for data transfer of gridded 2- and 3-dimensional (spatial) geophysical/geochemical scalar fields between grids of different resolutions.
edit: requires
easybuilders/easybuild-framework#1396