Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CP2K v.2.4.0 and CP2K with i-pi #993

Merged
merged 8 commits into from Mar 12, 2016

Conversation

tloizou
Copy link
Contributor

@tloizou tloizou commented Aug 6, 2014

Contributing CP2K v.2.4.0
A minor modification has been made in fix_compile_date_lastcvs.patch
Contributing also CP2K v.2.4.0 with support of i-pi python code (https://github.com/i-pi/i-pi)

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@@ -0,0 +1,509 @@
diff -rupN cp2k-2.4.0_ref/makefiles/Makefile cp2k-2.4.0/makefiles/Makefile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment what this patch does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wpoely86
Copy link
Member

wpoely86 commented Aug 6, 2014

ok to test

@tloizou
Copy link
Contributor Author

tloizou commented Aug 7, 2014

Configs have been modified as per your suggestions

@boegel
Copy link
Member

boegel commented Aug 7, 2014

Jenkins: ok to test

@boegel
Copy link
Member

boegel commented Sep 14, 2015

Jenkins: test this please

@boegel
Copy link
Member

boegel commented Sep 14, 2015

@wpoely86: please review

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4312/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

'cp2k-2.4.0_ipi.patch',
'fix_compile_date_lastcvs.patch',
'do_regtest_nocompile.patch'
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove spaces

@wpoely86
Copy link
Member

2 tiny remarks, else good to go.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4333/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4334/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4336/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestones: v2.4.0, merge sprint 2.0 Sep 16, 2015
sources = [SOURCELOWER_TAR_BZ2]

patches = [
'CP2K-2.4.0_ipi.patch',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferably, use %(version)s here (Same below)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please use %(version)s

@wpoely86
Copy link
Member

lgtm

@@ -0,0 +1,510 @@
#This patch makes CP2K source code compatible with i-pi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this come from? who created it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: This is a patch the i-pi developers created. It can be found here:
https://github.com/i-pi/i-pi/tree/master/patches

In the documentation it is explained that i-PI is distributed with patch files. When
applied to a clean distribution, these will adjust the source code to make it compatible
with i-PI. So, maybe I should modify the patch file and add a link from where I got the patch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying this in the patch @tloizou!

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4387/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4389/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

# about 100 tests fail
ignore_regtest_fails=True


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tloizou: missing moduleclass line

@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4426/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestones: merge sprint 2.0, v2.4.0, v2.5.0 Nov 9, 2015
@boegel boegel modified the milestones: v2.5.0, v2.6.0 Dec 14, 2015
@boegel boegel modified the milestones: v2.6.0, v2.7.0 Jan 23, 2016
@boegel
Copy link
Member

boegel commented Mar 11, 2016

Jenkins: test this please

@boegel boegel modified the milestones: v2.8.0, v2.7.0 Mar 11, 2016
@hpcugentbot
Copy link
Contributor

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7054/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Mar 12, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2098.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d07fb3e6e6f5849d6f3c for a full test report.

@boegel
Copy link
Member

boegel commented Mar 12, 2016

OK, going in (finally!).

Thanks @tloizou!

boegel added a commit that referenced this pull request Mar 12, 2016
Adding CP2K v.2.4.0 and CP2K with i-pi
@boegel boegel merged commit 6af4a65 into easybuilders:develop Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants