always filter hidden deps from list of dependencies

[boegel]

fix for #1134

hidden dependencies were not being filtered from the list of dependencies if --force was enabled, because the filtering was done as a part of the validate() method

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1267/
Test PASSed.

[boegel]

@wpoely86: please review?

[wpoely86]

looks fine

[boegel]

Thanks for the review @wpoely86. I'd like to look into a dedicated unit test before merging this in (already working on it).

[pescobar]

I think the error I am getting here is related to this......
https://gist.github.com/6dd473833bb61785432b

[boegel]

@pescobar: it looks like your libreadline/.6.3-goolf-1.7.20 module is broken because the ncurses/5.9-goolf-1.7.20 module is no longer around

[pescobar]

I am hitting another problem which I think it´s related to this.

I have a Python module working which has bzip2 as a hidden dependency:

$ grep bzip2 /soft/modules/all/Python/2.7.9-goolf-1.7.20
if { ![is-loaded bzip2/.1.0.6-goolf-1.7.20] } {
    module load bzip2/.1.0.6-goolf-1.7.20

But when I try to add a new python extension and rebuild it with "eb -k -f" easybuild crashes looking for the bzip2 module (NOT hidden)

$ eb --configfiles=easybuild.cfg /soft/installed_easyconfigs/Python/Python-2.7.9-goolf-1.7.20.eb -k -f

== FAILED: Installation ended unsuccessfully (build directory: /tmp/easybuild/Python/2.7.9/goolf-1.7.20): build failed (first 300 chars): EasyBuild crashed with an error (at easybuild/tools/toolchain/toolchain.py:296 in add_dependencies): add_dependencies: no module 'bzip2/1.0.6-goolf-1.7.20' found for dependency {'dummy': False, 'toolchain': {'version': '1.7.20', 'name': 'goolf'}, 'name': 'bzip2', 'full_mod_name': 'bzip2/1.0.6-goolf-

[boegel]

@pescobar: yes, that's the same bug, EB v1.16.1 doesn't honor the hiddendependencies when --force is used... This will be fixed in EasyBuild v2.0.

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1351/
Test PASSed.

[boegel]

Dedicated test for this issue is now included, so merging this in.

Thanks for the review @wpoely86!