Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different logger classes depending on prefix of requested logger #1171

Closed

Conversation

riccardomurri
Copy link
Contributor

As the title says: this allows external libraries (e.g., GC3Pie) to use stdlib logging, while EB continues to use its own logging facility.

It's a hack, however, that involves directly setting a module-level private variable...

This allows external libraries (e.g., GC3Pie) to use the stdlib logging,
while EB keeps using its own logging facility.
@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@riccardomurri
Copy link
Contributor Author

Jenkins: ok to test

1 similar comment
@boegel
Copy link
Member

boegel commented Feb 11, 2015

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1324/
Test FAILed.

@boegel
Copy link
Member

boegel commented Feb 11, 2015

Things are very broken now, it seems... Somehow EasyBuild isn't using an EasyBuildLog instance anymore?

Traceback (most recent call last):
  File "test/framework/options.py", line 1065, in test_deprecated
    log.deprecated('x', str(orig_value))
TypeError: deprecated() takes at least 4 arguments (3 given)
Traceback (most recent call last):
  File "test/framework/options.py", line 1028, in test_experimental
    log.experimental('x')
AttributeError: FancyLogger instance has no attribute 'experimental'
Traceback (most recent call last):
  File "test/framework/easyconfigparser.py", line 75, in test_v20
    ec = ecp.get_config_dict()
  File "easybuild/framework/easyconfig/parser.py", line 148, in get_config_dict
    return self._formatter.get_config_dict()
  File "easybuild/framework/easyconfig/format/two.py", line 99, in get_config_dict
    self.log.experimental(self.__class__.__name__)
AttributeError: FancyLogger instance has no attribute 'experimental'

@hpcugentbot
Copy link
Contributor

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/1329/
Test PASSed.

@riccardomurri
Copy link
Contributor Author

@boegel Fixed now, thanks for the heads-up.

@riccardomurri
Copy link
Contributor Author

A lighter-weight alternative to this is in #1179

@boegel
Copy link
Member

boegel commented Jun 24, 2015

same here as in #1179; this is a very complex workaround while https://github.com/hpcugent/easybuild-framework/pull/1008/files#diff-30c0c724e8b33847f917f22eca0af7a0R57 does the trick as well, and the raiseError aspect of EasyBuildLog has been deprecated (to disappear in EB v3.0), so this is no longer useful?

@riccardomurri
Copy link
Contributor Author

Yes, I agree to closing w/out merging

@boegel boegel closed this Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants