Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrgEnv-pgi support #1729

Merged
merged 19 commits into from May 17, 2016
Merged

PrgEnv-pgi support #1729

merged 19 commits into from May 17, 2016

Conversation

jgphpc
Copy link
Contributor

@jgphpc jgphpc commented Apr 20, 2016

PrgEnv-pgi support

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Apr 20, 2016

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2946/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Apr 20, 2016

@jgphpc please ignore the failing tests for now, there's something wrong on our Jenkins server

cc @JensTimmerman

@JensTimmerman
Copy link
Contributor

no lmod on jenkins0 yet, in this very particular place
jenkins test this please

@boegel boegel added this to the v2.8.0 milestone Apr 20, 2016
@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2947/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Apr 20, 2016

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2948/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

##
"""
CrayPGI toolchain: Cray compilers (PGI) and MPI via Cray compiler drivers (PrgEnv-pgi) minus LibSci minus Cray FFTW
@author: jgp (CSCS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgphpc please write out your full name? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgphpc please fix this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel done, do you see anything else wrong ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to go otherwise

@boegel
Copy link
Member

boegel commented May 11, 2016

@jgphpc now that #1342 is merged, you should resync this with develop

also, the file easybuild/tools/toolchain/craytoolchain.py should not be here at all, that's the easyblock that is used to install Cray* modules; it lives in the easyblocks repository: https://github.com/hpcugent/easybuild-easyblocks/blob/master/easybuild/easyblocks/generic/craytoolchain.py

I'd love to include this in EasyBuild v2.8.0, but then it should be made ready for merging today or tomorrow...

@boegel
Copy link
Member

boegel commented May 14, 2016

@jgphpc this should be merge ready if you merge jgphpc#1 to update this PR...

@boegel
Copy link
Member

boegel commented May 14, 2016

I've retested the HPL easyconfig with the two versions of CrayGNU, CrayIntel and CrayCCE we have included, all working fine.

@pforai
Copy link
Contributor

pforai commented May 17, 2016

LGTM, also a fairly small change.

@boegel
Copy link
Member

boegel commented May 17, 2016

Going in, thanks @jgphpc!

@boegel boegel merged commit 559a28b into easybuilders:develop May 17, 2016
boegel added a commit to boegel/easybuild-framework that referenced this pull request May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants