Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out duplicates in find_flexlm_license #1779

Merged
merged 1 commit into from May 27, 2016

Conversation

boegel
Copy link
Member

@boegel boegel commented May 25, 2016

This is probably enough to fix the regression reported in easybuilders/easybuild-easyblocks#933, but it seems like there's more going on (in IntelBase, that is).

@damianam: you're somewhat familiar with this, please review? ;)

@boegel boegel added this to the v2.8.1 milestone May 25, 2016
@boegel
Copy link
Member Author

boegel commented May 25, 2016

awaiting feedback from @MalkinE to see whether this helps with the reported issue

@MalkinE
Copy link

MalkinE commented May 26, 2016

This fixes the mentioned issue. Thanks @boegel!

@damianam
Copy link
Member

LGTM. But anybody reading this should probably know that this fix hides a potentially weirder problem (on Intel's side or in particular user configurations, where exactly is not clear) on the installation of intel tools. In particular, exist_lic should work with $INTEL_LICENSE_FILE, without further specifying a license file entry in silent.cfg.

This fix worked in the reported issue because with it we simply avoid setting exist_lic (unnecessarily) in favour of license_server or license_file.

@boegel
Copy link
Member Author

boegel commented May 27, 2016

Details on the latter are available at easybuilders/easybuild-easyblocks#933

Thanks for the review @damianam, and @MalkinE for confirming the fix!

@boegel boegel merged commit 8edb4e0 into easybuilders:develop May 27, 2016
@boegel boegel deleted the find_flexlm_license_dups branch May 27, 2016 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants