Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target correct path when using bunzip2 #1889

Merged
merged 1 commit into from Aug 26, 2016
Merged

Target correct path when using bunzip2 #1889

merged 1 commit into from Aug 26, 2016

Conversation

sebth
Copy link
Contributor

@sebth sebth commented Aug 26, 2016

The correct target path is not used when calling bunzip2 to handle
bzip2 files. This causes easyblocks such as BinariesTarball to fail for single bzip2 files.

To fix this problem, we can call bunzip2 the same way gunzip is called to handle gzip files. The gzip functionality has a test case to catch targeting errors, however the bzip2 functionality has not. We can add a similar test case to catch targeting errors for bzip2.

The target path was not correctly used when calling bunzip2 to handle
bzip2 files. Now bunzip2 is called the same way gunzip is called to
handle gzip files.
@boegel
Copy link
Member

boegel commented Aug 26, 2016

@sebth nice catch! Do you have an example easyconfig where you were hitting this problem with?

@boegel boegel added this to the v2.9.0 milestone Aug 26, 2016
@sebth
Copy link
Contributor Author

sebth commented Aug 26, 2016

@boegel: I have not found any in the repository, but I stumbled upon the bug when I wrote this:

easyblock = 'BinariesTarball'
name = 'XDSSTAT'
version = '20151203'

homepage = 'http://strucbio.biologie.uni-konstanz.de/xdswiki/index.php/Xdsstat'
description = ('A home-brewn program that prints various statistics '
               '(that are not available from XDS itself) in the form of '
               'tables and images.')

source_urls = ['ftp://turn5.biologie.uni-konstanz.de/pub/']
sources = ['%(namelower)s-linux64.bz2']
checksums = ['ddf18f58aa191dec91e112dc14982b36']

# XDSSTAT binary is linked to GCC runtime.
toolchain = {'name': 'goolf', 'version': '1.7.20'}
dependencies = [('CCP4', '7.0')]

# Default sanity_check_paths dirs include both 'bin' and 'lib'.
# XDSSTAT has no 'lib'.
sanity_check_paths = {'files': [], 'dirs': ['bin']}

moduleclass = 'data'

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Going in, thanks @sebth!

@boegel boegel merged commit 87329a7 into easybuilders:develop Aug 26, 2016
@sebth sebth deleted the develop branch August 26, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants