introduce future and depracted options, and log.future #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boegel is this what you wanted? (sans test ofcourse) |
| @@ -36,13 +36,18 @@ | |||
| import sys | |||
| from copy import copy | |||
| from vsc import fancylogger | |||
|
|
|||
There was a problem hiding this comment.
wai you drop empty line? we're purposely splitting easybuild imports from the others
|
@stdweird: I had something slightly different in mind, but this works too (and is probably better). I would just go for |
|
@boegel addressed remarks |
| ) | ||
| try: | ||
| log.experimental('x') | ||
| except: |
There was a problem hiding this comment.
except easybuild.tools.build_log.EasyBuildError, err:?
|
Jenkins: please test this |
…ild-framework into deprecated_future_option
use log.experimental for format v2 usage, and enable use of experimental is relevant unit tests
|
@boegel merged in |
|
going in, thanks @stdweird! |
boegel
added a commit
that referenced
this pull request
Feb 7, 2014
introduce future and depracted options, and log.future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.