Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a assign command vehicle behavior #980

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add a assign command vehicle behavior #980

wants to merge 2 commits into from

Conversation

Greenscreen23
Copy link
Contributor

@Greenscreen23 Greenscreen23 commented May 11, 2023 •
edited
Loading

PR Checklist

Please make sure to fulfil the following conditions before marking this PR ready for review:

  • If this PR adds or changes features or fixes bugs, this has been added to the changelog
  • If this PR adds new actions or other ways to alter the state, test scenarios have been added

@Greenscreen23 Greenscreen23 linked an issue May 11, 2023 that may be closed by this pull request
Allow vehicles as leaders of a simulated region #870
Open
@Greenscreen23
Copy link
Contributor Author

Merge hpi-sam/digital-fuesim-manv-public-test-scenarios#7 after this

@benn02 benn02 self-requested a review May 11, 2023 11:38
benn02
benn02 previously requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@benn02 benn02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a line to the UI of the Assign Leader behavior to which vehicle he belongs to Pretty Please (👉 👈 😊
grafik
)

@Greenscreen23 Greenscreen23 force-pushed the feature/870-allow-vehicles-as-leaders-of-a-simulated-region branch from 259e2bf to 84bc8a4 Compare May 12, 2023 11:58
@Greenscreen23 Greenscreen23 requested review from benn02 and removed request for benn02 May 12, 2023 11:59
@Greenscreen23 Greenscreen23 self-assigned this May 12, 2023
@Greenscreen23 Greenscreen23 dismissed benn02’s stale review May 12, 2023 12:00

Refactored the whole codebase

@Nils1729 Nils1729 self-requested a review May 15, 2023 11:42
@Nils1729
Copy link
Contributor

We discussed the design at hand and concluded that since this PR would remove the possibility for a single personnel to lead a region, further discussions are required.

Since the issue is non-critical at the time of writing, the work is deferred for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benn02 benn02 benn02 left review comments

@Nils1729 Nils1729 Awaiting requested review from Nils1729

At least 1 approving review is required to merge this pull request.

Assignees

@Greenscreen23 Greenscreen23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow vehicles as leaders of a simulated region
3 participants
@Greenscreen23 @Nils1729 @benn02