back to 100% code coverage

hpi-swt2 · Aug 19, 2017 · e661d72 · e661d72
1 parent 7a1f6ff
commit e661d72
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb
@@ -44,7 +44,7 @@ def update
   def set_contact_person
     @request = Request.find(params[:request_id])
     update_params = contact_person_params
-    if !update_params[:contact_person].nil? && @request.update(update_params)
+    if !update_params[:contact_person].empty? && @request.update(update_params)
       redirect_to @request, notice: I18n.t('requests.notice.was_updated')
     else
       render :show
@@ -54,7 +54,7 @@ def set_contact_person
   def set_notes
     @request = Request.find(params[:request_id])
     update_params = notes_params
-    if !update_params[:notes].nil? && @request.update(update_params)
+    if !update_params[:notes].empty? && @request.update(update_params)
       redirect_to @request, notice: I18n.t('requests.notice.was_updated')
     else
       render :show

diff --git a/spec/controllers/requests_controller_spec.rb b/spec/controllers/requests_controller_spec.rb
@@ -168,7 +168,7 @@
       context "with invalid params" do
         it "re-renders the 'show' template" do
           patch path, params: {request_id: @a_request.to_param, request: invalid_attributes, session: valid_session}
-          expect(response).to redirect_to(request_path(@a_request))
+          expect(response).to render_template('show')
         end
       end
     end