Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scales 1.0.0 release to break print.pprc() function #3

Open
dpseidel opened this issue Jul 27, 2018 · 0 comments
Open

scales 1.0.0 release to break print.pprc() function #3

dpseidel opened this issue Jul 27, 2018 · 0 comments

Comments

@dpseidel
Copy link

The upcoming scales 1.0.0 release is introducing a generic number formatter to power the formatting functions like ordinal() which voteogram imports. The new formatter expects numerics and fails when passed a character string. Based upon our revdep checks, this will break your roll_call() function which passes the numeric specified by the user in the number argument as a character to the print.pprc() which calls scales::ordinal().

We expect to release shortly and wanted to give you a heads up. Let me know if I can offer more clarity on the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant