-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The downloaded gitstatusd binary should be saved to an arch specific name #10
Comments
I can sympathise with this, since I do the same. Though because I have a homogenous set of systems it didn't occur to me. I think it makes sense to implement this. It's good timing too, because I have to rewrite the way binaries are updated due to romkatv/gitstatus#33. I kind of know what to do already, but haven't gotten around to it yet. For now, thanks for your report! |
That the author of
What makes me sad is that the gitstatusd author doesn't recognize that even using its primitive binary format there is no reason backward compatibility can't be maintained. At least across most updates to that tool. Even worse is they think that simply forcing everyone to update in lockstep with their project updates, as discussed in comment, is an acceptable strategy. |
I pushed an update with 7487ad9 that gets the latest gitstatus release, using separate paths per OS and arch. Please have a look and let me know if it works for you (it does for me). |
Works for me, @href. Thanks for the fix. |
You‘re welcome. Closing this issue. |
I sync my home directory (most of if it, anyway) to my other systems. The problem is that this elvish module saves the appropriate downloaded binary to ~/.elvish/package-data/gitstatusd. This causes problems if that directory is shared by platforms that have different operating systems (such as macOS and Linux) or architectures (such as ppc and x86_64). The downloaded binary should include the OS and architecture in the filename it is saved to. Note that this is easier, and cheaper, to do now that we have
$platform:os
and$platform:arch
.The text was updated successfully, but these errors were encountered: