Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future breaking update of Rspotify #287

Closed
marioortizmanero opened this issue Oct 18, 2020 · 3 comments
Closed

Future breaking update of Rspotify #287

marioortizmanero opened this issue Oct 18, 2020 · 3 comments

Comments

@marioortizmanero
Copy link

Hello!

I'm a maintainer of Rspotify. I picked up this library in July and have made lots of improvements since, with the help of the original maintainer. The library is now much cleaner, more flexible, and more performant. For now, these are the noticeable improvements for the end user:

  • async code has dropped from 206 (!!) compilation units (~1 min 29s on my machine) to 154 (~1min 10s)
  • blocking code has dropped from 207 compilation units (~1min 34s) to 103 (~1 min 1s) and now uses ureq
  • from 16310 LoC to 7268 (obtained with Tokei)
  • more clear documentation, getting started should be more straightforward
  • i intend to make an actual benchmark with more details

And we are just at 50% of the changes we intend to make, so it'll be even better. But these kind of improvements require breaking changes. A lot of them, in fact. I wanted to ask the maintainers of this crate (which is one of the most active ones using Rspotify) for help in some discussions relating the future of Rspotify:

Before the new release, we'd like to at least finish these changes, and afterwards we can keep adding new features and prepare for v1.0 in the far future. These include lots of proposals and changes, so don't feel the need to check out each of them. At least a bit of feedback will be useful to us.

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 18, 2020

Hey there, thanks a lot for the heads up and the work you're putting in, much appreciated. I'll try to go through the changes and post some remarks if I have any. 👍

@hrkfdn
Copy link
Owner

hrkfdn commented Nov 14, 2020

Closing this as there's nothing to do for now

@hrkfdn hrkfdn closed this as completed Nov 14, 2020
@marioortizmanero
Copy link
Author

Heads up: the new release is finally out! If you need help please let us know at ramsayleung/rspotify#218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants