Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Bug: Context menu not respecting highlight color from theme #431

Closed
sid-padture opened this issue Feb 18, 2021 · 3 comments
Closed

UI Bug: Context menu not respecting highlight color from theme #431

sid-padture opened this issue Feb 18, 2021 · 3 comments

Comments

@sid-padture
Copy link

Love this project, really amazing work.

I'd like to report a small UI bug: the context menu does not respect the "highlight" text color from the theme as you can see in this screenshot:

ncspot_bug

The highlight color is #000000 which works in the list view but in the context menu it is just using the primary color (#cccccc). Expected behavior is that the context menu would match the list view.

I would make a PR but I'm not very familiar with rust or cursive so I'm not sure the best way to apply the color to cursive::views::SelectView

@hrkfdn hrkfdn closed this as completed in a9f7f3c Aug 20, 2022
@hrkfdn
Copy link
Owner

hrkfdn commented Aug 20, 2022

Hey there, finally got around to fix this! :)

@BachoSeven
Copy link

BachoSeven commented Aug 23, 2022

@hrkfdn The last update broke my main colorscheme, and not in the context menu but in the main screens (so I assume it was the commit related to the issue). It was fine in 0.10.1

The issue is that that the primary color, used for the text on non-selected items for instance, is rendering diffferently from what it used to, making it unreadable.

Edit: Okay after checking the commits I realised the actual reason is the switch to termion (#894), which makes sense as months ago when I did the colorscheme I was using slightly different colors from the ones I wanted, since I guess pancurses it wasn't actually respecting the true colors but approximating them; now that there is truecolor support I will remove those workaround and adjust my theme to the colors I wanted. It's actually much better :)

@hrkfdn
Copy link
Owner

hrkfdn commented Aug 23, 2022

@BachoSeven Ah yes, that makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants