Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make play/pause indicators configurable #511

Closed
fwcd opened this issue May 3, 2021 · 10 comments
Closed

Make play/pause indicators configurable #511

fwcd opened this issue May 3, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@fwcd
Copy link
Contributor

fwcd commented May 3, 2021

The player currently displays the 'play icon' when a song is playing and the 'pause icon' when it's not playing. Since most traditional audio player GUIs do this the other way around, is there a specific reason for the current way?

@fwcd fwcd added the enhancement New feature or request label May 3, 2021
@hrkfdn
Copy link
Owner

hrkfdn commented May 4, 2021

Hmm, I'm not sure about this one. It's more of a playback status indicator than a button, that's why it's the way it currently is. I think if it were a button to toggle playback, it would make sense to reverse the icons, but in this case it seems rather counterintuitive to me. Any other thoughts?

@JojiiOfficial
Copy link
Contributor

I personally see it as button, even though I use 'P' to toggle playback. As @fwcd already pointed out, most audio player GUIs treat it as button and I think this point of view is preserved while using ncspot (at least in my case). In addition you can click the icon with the mouse to toggle playback as well. I was kinda confused the first time I used ncspot why the indicator status was inverted.

@codicodi
Copy link

codicodi commented May 4, 2021

It seems unintuitive to me as well (especially since I also use a custom MPRIS widget that always shows the opposite of what ncspot does). Maybe icons could be made configurable, similar to how colors are?

@ClashTheBunny
Copy link
Contributor

I do have to look at the time tick when I don't hear anything because it's not intuitive to me.

@AndydeCleyre
Copy link

Ha, I came here looking for the opposite bug.

I had no idea that was a button, so was sure it was a bug, showing the pause icon while the state is playing, as I considered the widget to be just like the shuffle icon, which shows a shuffle symbol when the state is shuffle.

So now I try clicking the shuffle icon (and elsewhere), and realize that the whole status bar is one big play/pause button.

So that little indicator, to me, is not a button, but an indicator, that happens to reside within a large toggle button.

I would appreciate an option to have the indicator show the current state again, rather than the opposite of the current state.

@BachoSeven
Copy link

https://xkcd.com/1172/ /s

@hrkfdn
Copy link
Owner

hrkfdn commented May 13, 2021

Haha, I feared this would happen 😄 It was meant to be an indicator actually. Maybe making it configurable is a good idea.

@hrkfdn hrkfdn reopened this May 13, 2021
@hrkfdn hrkfdn changed the title Suggestion: Flip play/pause indicators Make play/pause indicators configurable May 13, 2021
@hrkfdn hrkfdn closed this as completed in b42315d May 14, 2021
@hrkfdn
Copy link
Owner

hrkfdn commented May 14, 2021

Okay, I have reverted to the old behaviour and made this a configurable setting.

@fwcd
Copy link
Contributor Author

fwcd commented May 14, 2021

While I would argue that defaulting to the flipped version would be more intuitive for people used to traditional, button-style UIs, having it configurable is definitely nice and should make everyone happy 👍

@hrkfdn
Copy link
Owner

hrkfdn commented May 14, 2021

Yeah, I was kind of on the fence about this since I got reports from both camps, making it rather hard to decide. For me it's the other way round, coming from ncmpc which prints Playing: track title and as it was like this before as well, I reverted the change. Hope that's okay. Anyway, now people can decide for themselves. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants