Tighten up nulls #104
Tighten up nulls #104
Conversation
prdoyle
force-pushed
the
tighten-up-nulls
branch
from
245acfd
to
f59ef16
Compare
Might as well use the nearly identical built-in method.
prdoyle
force-pushed
the
tighten-up-nulls
branch
from
f59ef16
to
ac6eadd
Compare
|
@hrldcpr - I've attempted to make the commits logical to help you review these changes. If you review commit-by-commit it should all make sense. |
|
Awesome thanks! I'm a bit busy for the next several days, but I hope to look this over soon |
|
(still busy, until next week, but haven't forgotten) |
|
Hey @hrldcpr! Just checking in to see whether you're still planning to do a release with all these new goodies. If it's going to take more than a week or two, I'll just merge my changes using the prior version of pcollections, and upgrade once the new release is available. |
|
Sorry for the delay, this is great, thank you! I added a few small javadoc edits but other than that I think it's ready to merge. Thanks for the tip to go commit-by-commit, that was a nice way to review it. My one thought is that I'm tempted to make ConsPStack support nulls, I'll take a quick stab at that but then we can (finally) release 4.0.0! |
|
(Oh and great call swapping in |
|
Thanks @hrldcpr! Also nice catch on all those javadoc bugs. |
|
No problem! And I added some more null value testing, which uncovered a few subtle bugs - 0848dae I'm gonna try to add some similar null value testing for TreePMap tomorrow, because I have a feeling it might have some similar bugs - #106 Other than that we should be able to do a release soon, sorry for the delay. Though come to think of it I could just release all the pre-null stuff as 4.0.0 and then finish up testing the null stuff in no hurry and release it as 5.0.0… |
|
I got nulls working in the few remaining places, and am releasing v4.0.0 now! For some reason it takes a while to propagate to Maven Central, but should be there by tomorrow morning, lemme know if there's any issues |
|
@prdoyle 4.0.0 is live, it seems https://central.sonatype.dev/artifact/org.pcollections/pcollections/4.0.0 |
|
Thanks so much! I've brought it into my project now and it was super simple. |
Allow some, disallow others.
Supersedes #100. Fixes #54.