Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues #19

Merged
merged 8 commits into from Oct 30, 2022
Merged

Fixed issues #19

merged 8 commits into from Oct 30, 2022

Conversation

DizzasTeR
Copy link
Contributor

@DizzasTeR DizzasTeR commented Jun 22, 2022

Attempted to fix following:

About issue 12 and 13: I could not reproduce the issue before so not sure if they actually got fixed

A few other fixes including UI fixes and text color not updating with slider

I also forced a few theme colors (mainly dark) to stop the entire mess of colors mixing up

Most dependencies were updated

@Stefi16
Copy link

Stefi16 commented Jun 24, 2022

Hey, I recieve the following errors after running the code:
../Downloads/flutter/.pub-cache/git/image_editor_plus-25a3815edb84770bf6a854ec20459485f401dae9/lib/image_editor_plus.dart:1290:38: Error: The method 'build' isn't defined for the class 'ColorFilterGenerator'.

  • 'ColorFilterGenerator' is from 'package:colorfilter_generator/colorfilter_generator.dart' ('../Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/colorfilter_generator-0.0.6/lib/colorfilter_generator.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'build'.
    : selectedFilter.build(
    ^^^^^
    ../Downloads/flutter/.pub-cache/git/image_editor_plus-25a3815edb84770bf6a854ec20459485f401dae9/lib/image_editor_plus.dart:1405:21: Error: The method 'build' isn't defined for the class 'ColorFilterGenerator'.
  • 'ColorFilterGenerator' is from 'package:colorfilter_generator/colorfilter_generator.dart' ('../Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/colorfilter_generator-0.0.6/lib/colorfilter_generator.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'build'.
    child: filter.build(
    ^^^^^
    ../Downloads/flutter/.pub-cache/git/image_editor_plus-25a3815edb84770bf6a854ec20459485f401dae9/lib/image_editor_plus.dart:1535:18: Error: The method 'HandSignaturePainterView' isn't defined for the class '_ImageEditorDrawingState'.
  • '_ImageEditorDrawingState' is from 'package:image_editor_plus/image_editor_plus.dart' ('../Downloads/flutter/.pub-cache/git/image_editor_plus-25a3815edb84770bf6a854ec20459485f401dae9/lib/image_editor_plus.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'HandSignaturePainterView'.
    child: HandSignaturePainterView(

@DizzasTeR
Copy link
Contributor Author

Not sure why you're getting that, I changed the dependency package to my fork and it works fine. If it only happens when using my fork then I'll take a look

@Stefi16
Copy link

Stefi16 commented Jun 24, 2022

Yes it happens only using your forked repository

@DizzasTeR
Copy link
Contributor Author

Yes it happens only using your forked repository

Hmm, okay I'll see whats wrong then, maybe it works for me because of some cache thing, i'll try on a fresh project and let you know

@DizzasTeR
Copy link
Contributor Author

@Stefi16 Whats your compiledSdkVersion in /android/app/build.gradle

@Stefi16
Copy link

Stefi16 commented Jun 25, 2022

@DizzasTeR 31

@DizzasTeR
Copy link
Contributor Author

@Stefi16 Pushed some changes, pub get and pub upgrade and give it a go. Also you might need compiledSdkVersion of 33 and minSdkVersion 21 for some dependencies to work (Concluded this by starting a fresh project, and adding this package as dependency only)

@Stefi16
Copy link

Stefi16 commented Jun 27, 2022

Okay will test it thank you.

@volodymyr-perveev
Copy link

merge plese)

@hsbijarniya
Copy link
Owner

@DizzasTeR please update conflicting files.

# Conflicts Resolved:
#	lib/image_editor_plus.dart
#	pubspec.lock
#	pubspec.yaml
- Box decoration provides the color now
@hsbijarniya hsbijarniya merged commit 836c507 into hsbijarniya:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants