Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OO API + black formatting for episode 5 #88

Closed
amanmdesai opened this issue Jul 26, 2022 · 6 comments
Closed

OO API + black formatting for episode 5 #88

amanmdesai opened this issue Jul 26, 2022 · 6 comments

Comments

@amanmdesai
Copy link
Contributor

Following issue #83 for episode 5 mplhep

@amanmdesai amanmdesai changed the title OO API + black formatting for episode 1 OO API + black formatting for episode 5 Jul 26, 2022
@klieret
Copy link
Member

klieret commented Jul 26, 2022

To me it looks like episode 5 is already converted though, right? Or did I miss something?

@amanmdesai
Copy link
Contributor Author

when I ran black command, I see the following output:

1 file reformatted for some of the snippets

This is only for 4 of the snippets or so

@amanmdesai
Copy link
Contributor Author

To me it looks like episode 5 is already converted though, right? Or did I miss something?

Yes, you are right. Episode 5 is already converted.

Any other episode that needs to be converted?

@klieret
Copy link
Member

klieret commented Jul 26, 2022

when I ran black command, I see the following output:

1 file reformatted for some of the snippets

This is only for 4 of the snippets or so

Oh, if there's more, feel free to open PRs for it.

I'm not aware of any other snippets other than those of episode 1 (#83)

@amanmdesai
Copy link
Contributor Author

Hi, I tried to run black on some snippets and the comparison can be seen here:

https://github.com/hsf-training/hsf-training-matplotlib/compare/gh-pages...amanmdesai:hsf-training-matplotlib:test-episode-5-black?diff=split

Could you please take a look and see if this is what we want? (I am a bit confused here).

Thanks.

@klieret
Copy link
Member

klieret commented Jul 26, 2022

Oh, indeed!!

I had only taken a quick look and thought it had already been applied.

Yes, please open a PR for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants