Merge pull request #476 from hshoff/harry-fix-horiz-boxplot

[stats] fix horizontal boxplot in @vx/stats
airbnb · Jul 9, 2019 · c472afd · c472afd
2 parents 86e3a6f + e101f89
commit c472afd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/vx-boxplot/src/boxplots/BoxPlot.js b/packages/vx-boxplot/src/boxplots/BoxPlot.js
@@ -125,7 +125,7 @@ export default function BoxPlot({
   if (horizontal) {
     boxplot.max = verticalToHorizontal(boxplot.max);
     boxplot.maxToThird = verticalToHorizontal(boxplot.maxToThird);
-    boxplot.box.y1 = valueScale(firstQuartile)
+    boxplot.box.y1 = valueScale(firstQuartile);
     boxplot.box = verticalToHorizontal(boxplot.box);
     boxplot.median = verticalToHorizontal(boxplot.median);
     boxplot.minToFirst = verticalToHorizontal(boxplot.minToFirst);

diff --git a/packages/vx-stats/src/boxplot/BoxPlot.js b/packages/vx-stats/src/boxplot/BoxPlot.js
@@ -125,8 +125,8 @@ export default function BoxPlot({
   if (horizontal) {
     boxplot.max = verticalToHorizontal(boxplot.max);
     boxplot.maxToThird = verticalToHorizontal(boxplot.maxToThird);
-    boxplot.box = verticalToHorizontal(boxplot.box);
     boxplot.box.y1 = valueScale(firstQuartile);
+    boxplot.box = verticalToHorizontal(boxplot.box);
     boxplot.median = verticalToHorizontal(boxplot.median);
     boxplot.minToFirst = verticalToHorizontal(boxplot.minToFirst);
     boxplot.min = verticalToHorizontal(boxplot.min);