Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pack, Partition, and Treemap hierarchical layouts. Closes #172 #173

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

techniq
Copy link
Collaborator

@techniq techniq commented Oct 12, 2017

I also updated Tree and Cluster to only pass a single param to the child render function. Based on this:

image

I thought it made sense to swap data and root names, so now a layout component takes in a data prop (instead of root) and the child render function receives a root prop (instead of data, along with removing descendants, links, etc).

This also makes it more consistent with BarGroup, BarStack, Projection, etc. I can be talked out of this, but it seemed like it made sense, and since we were already making a breaking change with the number of params passed to the children function, I thought it was worth changing.

… meanings and simplify child render function params.
@hshoff
Copy link
Member

hshoff commented Oct 12, 2017

This is great. Happy to merge it. Tests are failing on travis right now, so don't worry about that. I'll get that fixed soon #171.

Let's keep it root over data. My reasoning is you're getting back a hierarchy root node that has all the special methods like descendants, links that wouldn't be on a raw data object like an array of objects. Once that change is made I'll get this merged, make some new tiles, add mock data and cut a 0.0.143 release.

@hshoff hshoff added this to the v0.0.143 milestone Oct 12, 2017
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data => root

@techniq
Copy link
Collaborator Author

techniq commented Oct 12, 2017

Done

@hshoff hshoff merged commit 4545626 into airbnb:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants