Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grid] Add tickValues prop #376

Merged
merged 3 commits into from
Oct 21, 2018
Merged

[grid] Add tickValues prop #376

merged 3 commits into from
Oct 21, 2018

Conversation

robinsoncol
Copy link
Contributor

@robinsoncol robinsoncol commented Oct 20, 2018 •
edited
Loading

🚀 Enhancements

  • Allow passing in tickValues prop to both Columns and Rows, to render grid lines at specific values.
  • Allow passing in rowTickValues prop and columnTickValues prop to Grid
  • Update vx-grid's Readme.md to reflect the changes above

One of the benefits of this feature is that it allows the alignment of grid lines to the tickValues passed into Axis components.

hshoff
hshoff approved these changes Oct 21, 2018
View reviewed changes
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for the contribution!

@hshoff hshoff added this to the v0.0.180 milestone Oct 21, 2018
@hshoff hshoff merged commit 489bad2 into airbnb:master Oct 21, 2018
@hshoff
Copy link
Member

hshoff commented Nov 13, 2018

Apologies for the delay, this is now published in v0.0.180 https://github.com/hshoff/vx/releases/tag/v0.0.180

@f1multiviewer f1multiviewer mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
🚀enhancement
Projects
None yet
Milestone
v0.0.180
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robinsoncol @hshoff