Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shape/BarGroupHorizontal] Remove unnecessary destructuring of props in demo code #409

Conversation

pajkicdj
Copy link
Contributor

@pajkicdj pajkicdj commented Jan 9, 2019

💥 Breaking Changes

  • None, only updated string value.

🚀 Enhancements

  • N/A

📝 Documentation

  • No need to update any additional documentation

🐛 Bug Fix

  • As a d3 first-timer and react long-timer, I was excited to dip my toes in with vx. I followed the demo code, however I was struck with an angry error screen:

screen shot 2019-01-09 at 1 58 28 pm

After a bit of debugging I realized the issue lay with the demo code. The children fn parameter in the demo code was expecting an argument to destructure and then map over the resulting barGroups value. However in the BarGroupHorizontal component in vx/packages/vx-shape/src/shapes/BarGroupHorizontal.js on line 66 it was only ever being passed one argument of type array. Therefore, removing the unnecessary destructuring of barGroups resolved the issue.

🏠 Internal

  • N/A

@hshoff hshoff added the 🐛 bug label Jan 9, 2019
@hshoff hshoff added this to the v0.0.184 milestone Jan 9, 2019
Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants