Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate @vx/boxplot #561

Merged
merged 8 commits into from Dec 18, 2019
Merged

deprecate @vx/boxplot #561

merged 8 commits into from Dec 18, 2019

Conversation

williaster
Copy link
Collaborator

💥 Breaking Changes

This PR closes #560 and removes all references to @vx/boxplot whose functionality is duplicated in the @vx/stats package and has confused some users (e.g., #412)

#197 note: @vx/boxplot is deprecated in favor of @vx/stats in a future release @vx/boxplot will be removed

After this is merged I will add a deprecation warning to npm:
npm deprecate @vx/boxplot "@vx/boxplot has been deprecated in favor of @vx/stats"

@hshoff @conglei

@williaster williaster added this to In progress in TypeScript via automation Dec 13, 2019
@williaster williaster removed this from In progress in TypeScript Dec 13, 2019
@williaster
Copy link
Collaborator Author

one possible issue is with the docs, I'm not sure if we run the docs script while in the TS/JS limbo, and currently most of the docs *.html pages have references to vx-boxplot.html. I'll try to search/replace scrub these for now.

@williaster
Copy link
Collaborator Author

going to merge this guy because some of the lint errors it fixes are failing the build in other PRs. Can follow up with any issues in another PR.

@williaster williaster merged commit 5a6f103 into master Dec 18, 2019
@williaster williaster deleted the chris--remove-boxplot branch December 18, 2019 19:43
@williaster
Copy link
Collaborator Author

noting successful deprecation on npm

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate @vx/boxplot
1 participant