Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(vx-scale) add scaleSqrt #615

Merged
merged 2 commits into from
Jan 30, 2020
Merged

new(vx-scale) add scaleSqrt #615

merged 2 commits into from
Jan 30, 2020

Conversation

dennisja
Copy link
Contributor

@dennisja dennisja commented Jan 29, 2020 •
edited
Loading

🚀 Enhancements

  • Add scaleSqrt

📝 Documentation

  • Add scaleSqrt documentation

Fixes #604

@dennisja dennisja changed the title Scale sqrt Add scaleSqrt Jan 29, 2020
williaster
williaster approved these changes Jan 30, 2020
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding tests and docs! 💖

@williaster williaster changed the title Add scaleSqrt new(vx-scale) add scaleSqrt Jan 30, 2020
@williaster williaster added this to the v0.0.194 milestone Jan 30, 2020
@williaster williaster merged commit 5494771 into airbnb:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
📝 docs 🚀enhancement
Projects
None yet
Milestone
v0.0.194
Development

Successfully merging this pull request may close these issues.

@vx/scales could use a Square-Root scale
2 participants
@dennisja @williaster