Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vx-brush): update to docgen #698

Merged
merged 2 commits into from
May 22, 2020
Merged

Conversation

williaster
Copy link
Collaborator

📝 Documentation

Part of #680, updates @vx/brush docs to the new non-static docgen, and adds types to the Brush component to make this way more useful.

After
image

Before
image

@hshoff @kristw

@williaster williaster mentioned this pull request May 13, 2020
@williaster williaster added this to the v1 milestone May 13, 2020
@@ -37,7 +37,6 @@
"@vx/group": "0.0.196",
"@vx/shape": "0.0.196",
"classnames": "^2.2.5",
"prop-types": "^15.6.1",
"recompose": "^0.23.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@williaster williaster merged commit 32c820c into chris--fix-docgen May 22, 2020
@williaster williaster deleted the chris--docgen-brush branch May 22, 2020 21:50
@hshoff hshoff modified the milestones: v1, v0.0.197 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V1
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants