internal(vx-demo): sandbox cleanup #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
approved these changes
May 23, 2020
|
Just tried the codesandbox link for Geo Mercator on a few different browsers and I'm not able to get it to load for some reason..
Just wanted to check if this issue is isolated to just me. |
|
@ryee-dev are you using the link from https://vx-demo.now.sh/ ? Sorry, we need a deprecation notice for that. The demo has now moved to airbnb.io/visx, and the sandbox links have changed https://airbnb.io/visx/geo-mercator now links to https://codesandbox.io/s/github/airbnb/visx/tree/master/packages/visx-demo/src/sandboxes/visx-geo-mercator Hope that helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR cleans up some remaining items for the demo codesandbox refactor and should close #624 🎉 It specifically
src/v2-docs/examples/*=>src/sandboxes/*"private": true"to each sandboxpackage.jsonsince they shouldn't be published.jsfiles insrc/components/codeblocks,charts,utilTesting
Gallerystill works (which should test each example)CodeSandboxLinklink works (example, update to master branch upon merge)@hshoff @kristw